fix(agent): recreate large shared allocations on restore - #165
galletas1712 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
ed51e91 to
0cc1964
Compare
0cc1964 to
4cabaf6
Compare
4cabaf6 to
f537c58
Compare
f537c58 to
3d30d21
Compare
10cc986 to
3d30d21
Compare
Signed-off-by: Schwinn Saereesitthipitak <schwinns@nvidia.com>
3d30d21 to
fcbfd10
Compare
|
Superseded by #218 (lifecycle: host carrier for every tracked creator allocation, restored through one pinned arena per process). The re-cut stack (#212 → #220) supersedes this PR. Its body is quoted verbatim in the replacement's Origin section, and each review thread here has a row in the replacement's "Review threads carried" table with what was done about it. |
Summary
test_cucheckpoint.pywithout changing the production threshold, and assert that no carrier files appearThis is a transparent r615 workaround for large shared allocations whose bytes restore but whose original post-restore POSIX export state is stale. It does not change the driver, disable FLA/FABRIC, require GMS, or retain a second device allocation. Small, non-shared, non-POSIX-exportable, and non-device allocations remain on the native CUDA checkpoint path.
Validation
CUDA_ERROR_INVALID_VALUEHOST_CARRIER_THRESHOLD=1, exercises the carrier path, and rejects anycuinterposer-host-*.binartifact17 * 23 = 391-Wall -Wextra -Werrorgit diff --checkpython3 -m py_compile agent/cmd/cuinterpose/tests/test_cucheckpoint.py