Conversation
Signed-off-by: Maksim Khadkevich <mkhadkevich@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Repeated restore reconciliations apply the same
nvidia.com/Restoredcondition even when its status, reason, and message have not changed. Each no-op write creates a new Pod resource version and triggers another informer event.Why
Restore dependencies can remain pending across several reconciliations. Avoiding identical status writes reduces API server traffic and self-induced reconciliation, especially when many restores run concurrently.
Change
Skip the status apply when the existing condition already matches. Real transitions continue through server-side apply and retain the existing
LastTransitionTimebehavior.Testing
Fixes #353