Skip to content

fix(agent): skip unchanged restored condition writes - #354

Draft
hutm wants to merge 1 commit into
ai-dynamo:mainfrom
hutm:review/idempotent-restored-condition
Draft

hutm wants to merge 1 commit into
ai-dynamo:mainfrom
hutm:review/idempotent-restored-condition

Conversation

@hutm

@hutm hutm commented Sep 17, 2026

Copy link
Copy Markdown

Problem

Repeated restore reconciliations apply the same nvidia.com/Restored condition even when its status, reason, and message have not changed. Each no-op write creates a new Pod resource version and triggers another informer event.

Why

Restore dependencies can remain pending across several reconciliations. Avoiding identical status writes reduces API server traffic and self-induced reconciliation, especially when many restores run concurrently.

Change

Skip the status apply when the existing condition already matches. Real transitions continue through server-side apply and retain the existing LastTransitionTime behavior.

Testing

  • Added coverage for skipping an identical condition and persisting a changed condition.
  • Ran the complete agent test suite.

Fixes #353

Signed-off-by: Maksim Khadkevich <mkhadkevich@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid no-op restored condition status writes

1 participant