Conversation
Signed-off-by: Maksim Khadkevich <mkhadkevich@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every Kubernetes Event write currently blocks checkpoint or restore reconciliation. A slow Event API request can delay the workload even though Normal events are best-effort telemetry.
Why
Informational event delivery should not be part of the restore critical path. Warning events still need synchronous error reporting.
Change
Publish Normal events through a bounded worker queue. Keep Warning events synchronous, copy queued Pod data, and drop a Normal event with a diagnostic when the queue is full.
This removes a blocking dependency from the critical path, but local end-to-end measurements did not show a statistically significant latency improvement.
Testing
Fixes #351