Skip to content

feat(agent): log restore controller phase timings - #356

Draft
hutm wants to merge 1 commit into
ai-dynamo:mainfrom
hutm:review/restore-controller-timings
Draft

hutm wants to merge 1 commit into
ai-dynamo:mainfrom
hutm:review/restore-controller-timings

Conversation

@hutm

@hutm hutm commented Sep 17, 2026

Copy link
Copy Markdown

Problem

Restore timing starts inside the executor, leaving controller work such as preflight validation and finalizer updates unaccounted for.

Why

Without controller-stage timing, operators cannot tell whether a slow restore spent time preparing the request or executing CRIU and CUDA restore.

Change

Log one structured timing summary per controller pass with total, preflight, finalizer, and restore durations, plus the stage where the pass returned.

Testing

  • Added coverage for the structured timing fields on a preflight failure.
  • Ran the complete agent test suite.

Fixes #350

Signed-off-by: Maksim Khadkevich <mkhadkevich@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add restore controller phase timing

1 participant