Conversation
Signed-off-by: Maksim Khadkevich <mkhadkevich@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The restore controller already has the scheduled Pod from its informer, but GPU discovery performs another Pod GET before deciding whether DRA is relevant.
Why
For Pods without resource claims, the immutable Pod spec already proves that DRA lookup is unnecessary. Removing the redundant GET reduces API traffic and avoids an extra request on the restore path.
Change
Reuse the observed Pod when its identity matches and it has no resource claims. Pods that may use DRA retain the live Pod lookup because generated claim names arrive through Pod status. GPU assignment still comes from kubelet PodResources.
Local phase measurements showed a smaller GPU-discovery preflight, but no statistically significant end-to-end latency improvement.
Testing
Fixes #352