build(helm): include license in chart package - #359
saturley-hall wants to merge 1 commit into
Conversation
Signed-off-by: Harrison King Saturley-Hall <hsaturleyhal@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review. WalkthroughThe chart adds a relative ChangesLicense packaging
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The chart license link and packaging documentation align with the stated change, with no actionable merge risk identified. 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Comment |
| The `charts/snapshot/LICENSE` entry is a symbolic link to that top-level file. It exists only so | ||
| Helm includes the license when packaging the chart; Helm dereferences the link and writes a | ||
| regular-file copy into the chart archive. |
There was a problem hiding this comment.
Why do we need to explain that in the README?
What type of PR is this?
What this PR does / why we need it:
Adds a relative
charts/snapshot/LICENSEsymlink to the repository-level Apache-2.0 license and documents that it exists only for packaging. Helm dereferences the link into a regular file in the published chart archive.Which issue(s) this PR fixes:
Fixes #358
How was this tested?
make verify-crds verify-license-headers helm-lint verify-tocsnapshot/LICENSEis a regular file byte-identical to the repositoryLICENSEgit diff --checkSpecial notes for your reviewer:
The full
make checkreachedpagebroker-check-generatedbut could not execute the repository-bootstrappedprotocbinary on macOS arm64. The targeted checks relevant to this change pass.Does this PR introduce an API change?
Additional documentation, e.g. enhancement proposals, usage docs:
Checklist
git commit -s), per CONTRIBUTING.mdmake check testpasses locallySummary by CodeRabbit