Make downloader manifest-aware#3
Open
Songard wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the download/ tooling to treat the public Hugging Face manifest (wanderland_public_manifest.csv) as the source of truth for released scenes, and introduces a manifest-driven scene selection mode via --quality-tier.
Changes:
- Add public-manifest loading + summary output and validate scene selection against the manifest.
- Add
--quality-tierscene selection option, with--countacting as an optional limiter across selection modes. - Update
download/README.mdexamples to use manifest tiers (showcase,evaluation_ready,training_ready) as the primary recommended workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| download/download.py | Loads and summarizes the public manifest, adds --quality-tier, and validates requested scenes against manifest entries. |
| download/README.md | Replaces legacy split-file-centric examples with manifest tier-based download examples and documents the manifest as source of truth. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+43
to
+49
| for row in reader: | ||
| scene_id = row.get("scene_id", "").strip() | ||
| if not scene_id: | ||
| continue | ||
| row["scene_id"] = scene_id | ||
| row["quality_tier"] = row.get("quality_tier", "").strip() | ||
| rows.append(row) |
Comment on lines
+60
to
+62
| versions = sorted({row.get("manifest_version", "").strip() for row in rows if row.get("manifest_version", "").strip()}) | ||
| updated_at = sorted({row.get("manifest_updated_at", "").strip() for row in rows if row.get("manifest_updated_at", "").strip()}) | ||
| tiers = Counter(row.get("quality_tier", "").strip() or "unspecified" for row in rows) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Wanderland download tool to use the public manifest as the source of truth for released scenes.
Changes:
wanderland_public_manifest.csvfrom Hugging Face before selecting scenes.--quality-tierfor manifest-based downloads, e.g.showcase,evaluation_ready,training_ready.showcaseas the first recommended Quick Start example, but do not make it the default.--all,--scenes, and--scene-list, while validating selected scenes against the manifest.download/README.mdso the main path uses manifest tiers instead ofeval_scenes_v1.txt/train_scenes_v1.txt.