Fix/artifact manager auto reconnect#86
Merged
Merged
Conversation
When the Artifact Manager becomes unreachable, the snapshot upload proxy goes stale. Previously there was no recovery short of a service restart. Now SquidArtifactManager.refresh_service() re-acquires the proxy from the existing WebSocket connection, and the upload path automatically retries once with the fresh proxy on timeout/connection errors. Also rate-limits flush-loop warnings to once per 60 seconds and logs exception type names so asyncio.TimeoutError no longer appears blank. Co-Authored-By: DeepSeek-V4-Pro <noreply@deepseek.com>
The reconnect logic in _upload_to_artifact_manager only caught TimeoutError/ConnectionError/OSError, but hypha_rpc RPC failures raise RemoteException. During a brief Artifact Manager outage at 21:28 UTC, 4 snaps failed with RemoteException without triggering a proxy refresh. The images were still saved locally and recovered by the flush loop, but adding RemoteException to the retry trigger will recover faster next time. Co-Authored-By: DeepSeek-V4-Pro <noreply@deepseek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.