Skip to content

fix: harden scanner quality paths#24

Merged
limaronaldo merged 2 commits into
mainfrom
codex/code-quality-fixes
Jun 20, 2026
Merged

fix: harden scanner quality paths#24
limaronaldo merged 2 commits into
mainfrom
codex/code-quality-fixes

Conversation

@limaronaldo

@limaronaldo limaronaldo commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Split the CLI command implementations into focused modules while keeping the public command surface unchanged.
  • Harden shell backtick parsing and SHIELD-016 unsafe deserialization detection, including comment/string/doc false-positive coverage.
  • Remove unused direct Rust dependencies and update parser docs for the current Python regex parser behavior.
  • Add a harness PR-title policy guard that rejects titles containing [codex].

Verification

  • rtk cargo fmt --check
  • rtk cargo test
  • rtk cargo clippy -- -D warnings
  • rtk cargo test --workspace --all-features
  • rtk cargo clippy --workspace --all-targets --all-features -- -D warnings
  • rtk cargo check --no-default-features --all-targets
  • rtk cargo check --no-default-features --features python --all-targets
  • rtk cargo machete
  • rtk npm run compile in vscode/
  • Targeted CLI smokes for SHIELD-001 shell backticks and SHIELD-016 pickle.loads
  • rtk bash docs/harness/bin/doctor.sh
  • rtk bash docs/harness/bin/sensors.sh docs
  • rtk bash docs/harness/bin/sensors.sh quick
  • rtk bash docs/harness/bin/pr-title-policy.sh --current-pr

Review

  • Post-fix code-quality review: APPROVE, no blockers.
  • Harness PR-title policy review: PASS, no blockers.

@limaronaldo limaronaldo marked this pull request as ready for review June 20, 2026 14:51
@limaronaldo limaronaldo merged commit 902c26b into main Jun 20, 2026
9 checks passed
@limaronaldo limaronaldo deleted the codex/code-quality-fixes branch June 20, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant