Fix pandas StringDtype compatibility in anomalies module#362
Closed
Fix pandas StringDtype compatibility in anomalies module#362
Conversation
- Use pd.api.types.is_string_dtype() instead of checking for dtype == "object" - This handles both object dtype (older pandas) and StringDtype (newer pandas) - Update test to use is_string_dtype() for dtype assertions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix test failures caused by pandas version differences in string dtype handling.
Changes
pd.api.types.is_string_dtype()instead of checkingdtype == "object"inanomalies.pytest_anomalies.pyto useis_string_dtype()for dtype assertionsProblem
Newer pandas versions infer string columns as
StringDtypeinstead ofdtype('O')(object), causing:test_encode_categorical_columnsto fail on dtype assertionstest_return_anomalies_idxto fail because string columns weren't being encodedSolution
The
pd.api.types.is_string_dtype()function handles both old (object) and new (StringDtype) pandas behavior.Test plan
🤖 Generated with Claude Code