migration: guard asynchronous Dokploy deploys - #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dokploy queues
compose.deploywork and fetches enabled patches later, so immediate request-time checks could not prove that the reviewed compose definition was deployed. This republishes the reviewed compose and environment asrawimmediately before each deploy, monitors a uniquely titled attempt through terminal status, and fails closed by quiescing the target when monitoring or the final guard cannot establish safety.The same guarded path covers discovery redeploys, and route changes reject active non-raw Bort overrides before the first planned domain mutation. HTTP status and transport failures remain distinct so authoritative rejections return directly while genuinely ambiguous requests are resolved by title.
Dokploy has no atomic fence for unrelated external deployments; quiescence therefore considers every visible deployment and repeatedly stops observed target containers before recovery.