Minor fixes for BAMT users - #169
Open
gkirgizov wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 74.13% 74.09% -0.04%
==========================================
Files 129 129
Lines 7673 7683 +10
==========================================
+ Hits 5688 5693 +5
- Misses 1985 1990 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gkirgizov
marked this pull request as ready for review
August 24, 2023 05:34
YamLyubov
reviewed
Aug 31, 2023
| self.generations = GenerationKeeper(self.objective, keep_n_best=requirements.keep_n_best) | ||
| self.timer = OptimisationTimer(timeout=self.requirements.timeout) | ||
|
|
||
| dispatcher_type = MultiprocessingDispatcher if self.requirements.parallelization_mode == 'populational' else \ |
Collaborator
There was a problem hiding this comment.
Насколько я помню, параметер parallelization_mode вынесен в api в федоте. Такие изменения вообще делают его не нужным. Стоит эти изменения согласовать с федотом
Collaborator
|
Доделаю или закрою, если окажется, что уже не актуально |
Collaborator
|
@gkirgizov этот PR ещё актуален? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.