Skip to content

Increase test coverage - #236

Draft
kasyanovse wants to merge 2 commits into
mainfrom
224-increase-test-coverage
Draft

Increase test coverage#236
kasyanovse wants to merge 2 commits into
mainfrom
224-increase-test-coverage

Conversation

@kasyanovse

Copy link
Copy Markdown
Collaborator

@kasyanovse kasyanovse added the test Adding or fixing tests label Oct 31, 2023
@kasyanovse kasyanovse linked an issue Oct 31, 2023 that may be closed by this pull request
@pep8speaks

Copy link
Copy Markdown

Hello @kasyanovse! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 2:1: F401 'itertools.product' imported but unused
Line 40:1: E302 expected 2 blank lines, found 1

@kasyanovse kasyanovse changed the title Increase tests coverage Increase test coverage Oct 31, 2023
@kasyanovse
kasyanovse marked this pull request as draft December 28, 2023 07:01
@nicl-nno

Copy link
Copy Markdown
Collaborator

@kasyanovse это можно ревьюить? Или уже неактуальны измения?

@kasyanovse

Copy link
Copy Markdown
Collaborator Author

@kasyanovse это можно ревьюить? Или уже неактуальны измения?

Именения актуальные. До ревью еще очень далеко. Хотя, если ишью в описании неактуален, то и этот пр не актуален.

@nicl-nno

nicl-nno commented Feb 12, 2024

Copy link
Copy Markdown
Collaborator

Ишью актуален. Но мб какие-то из новых тестов самодостаточны и их можно влить уже? Если нет то нет.

@kasyanovse

kasyanovse commented Feb 14, 2024

Copy link
Copy Markdown
Collaborator Author

Ишью актуален. Но мб какие-то из новых тестов самодостаточны и их можно влить уже? Если нет то нет.

Точно не помню, но должны быть самодостаточными. Можешь вливать, как посчитаешь нужным.

@nicl-nno

Copy link
Copy Markdown
Collaborator

@maypink как считаешь, вливаем (убрав закомментированное)?

- resolve the conflict in AdaptiveMutationProb (keep _min_proba = 0.1 from main);
  relax the validation to (0, 1] since values below _min_proba are clamped
  by next() anyway and should not break existing configurations
- fix wording of the validation error messages
- implement the previously commented-out decremental regularization test;
  it exposed a latent bug: Regularization was never given GraphRequirements,
  so decremental mode crashed with AttributeError on
  requirements.static_individual_metadata. Regularization now accepts
  requirements (like the other operators) and EvoGraphOptimizer passes them
- add a test for decremental regularization on graphs without fitted subtrees
- revert the docstring change in test_custom.py ('sane result' was intended)
- remove an unused import
@codecov-commenter

codecov-commenter commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.24%. Comparing base (2ee6d82) to head (fc74b31).

Files with missing lines Patch % Lines
...re/optimisers/genetic/parameters/operators_prob.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   72.71%   73.24%   +0.53%     
==========================================
  Files         142      142              
  Lines        8450     8461      +11     
==========================================
+ Hits         6144     6197      +53     
+ Misses       2306     2264      -42     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Adding or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase test coverage

4 participants