Conversation
Seeded flights still store missing /static/images/airlines/<slug>.svg paths (issue aiming-lab#22 / stale aiming-lab#23). Resolve marks at render time to committed 70px gstatic PNGs under static/icons/airlines/{IATA}.png so logos render without waiting on HF discussion aiming-lab#11, whose tarball is logos-only. Co-authored-by: Xuanrui Li <xuanrui.li@se24.qmul.ac.uk>
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewer takeover for #22 (Google Flights airline logos) on
Lxr-max/WebHarbor. Stale author PR: #23.#23 only retargeted
seed_data.pyfrom.svgto.png. That does not fix the published seed DB (126k rows still store/static/images/airlines/<slug>.svg), and the paired HF discussion #11 is a logos-onlygoogle_flights.tar.gz(~48 KB) that must not replace the full site archive.This PR follows the same code-side fallback as ESPN #132:
/flights/airline_logos/70px/{IATA}.png) undersites/google_flights/static/icons/airlines/(git-tracked, not HF-managed).<img>URLs at render time so templates never request a missing file and neveronerror-hide a broken image.seed_data.pyrows at/static/icons/airlines/{airline_code}.png.Does not touch Best Buy, the site registry, or
.assets-revision.Fixes #22.
Verification
8/8 tests OK. Flask
test_clientagainst the pinnedgoogle_flightsseed:/flights,/search?q=Delta,/flight/<id>return 200 and emit/static/icons/airlines/{IATA}.png/static/images/airlines/*.svgGET /static/icons/airlines/{AA,DL,…,QF}.png→ 200 image/png (PNG signature) for all 23 codesLive Chromium against standalone Flask on
:41007(pinned seed copied toinstance/):/flights?from=JFK&to=LAX&depart=2024-01-01shows the American Airlines gstatic mark/search?q=Deltashows the Delta widget on every result row/flight/733“Other flights on this route” shows Qatar, JetBlue, Spirit, Delta, Frontier marksDocker image rebuild /
/resetbyte-identity was not re-run here (no Docker daemon; seed DB untouched).Lineage
hqhq1025, seed path.svg→.pngonly)