Fix Bandcamp grading, mobile layout, and merged asset integration - #146
Merged
Merged
Conversation
…am tone Drop the artificial 24-tag limit on Discover so tag-filtered tasks reach their targets, and replace benchmark-facing copy (mock checkout, seeded benchmark users, About This Mirror) with upstream-style user copy.
…ma fixtures Rewrite the 18 judge rubrics as deterministic fact checkpoints derived from the initial database, rework verify_lib around identity/format invariants, and add seed/schema fixture tests plus a task 9/11 regression test. No question text, mappings, or answers change.
…ayout Generated SVG (seed_data): auto-fit cover/merch label text so long titles stay inside the viewBox and backdrop instead of clipping, widen merch backdrops, and stop truncating merch titles mid-word. CSS: stop stat pills stretching inside album-copy grid; keep single-item release/merch grids at card width (auto-fill); show full merch art at its native 5:6 ratio instead of a 1:1 crop that cut the bottom label; widen the purchase column and shrink select text so option prices are not hidden under the dropdown arrow; give the category pill row a visible scroll affordance; deepen the artist hero overlay so stats stay legible. JS: ignore Enter on focused selects so it cannot implicitly submit the cart form with the default variant, and emit English native-validation messages regardless of browser locale.
Integrate upstream additions (Rotten Tomatoes, Compass, Walmart Careers) and move Bandcamp from site 23 (port 40021) to site 25 (port 40024): registry lists in websyn_start.sh/control_server.py stay identical, Dockerfile EXPOSE and README counts/ports updated, bandcamp app default port and task web fields moved to 40024.
The shared preview-toggle handler wrote "Preview mock" once a panel was collapsed again, so every album page showed the wrong label on the second click. Restore it to "Preview" to match the initial button text. Found by manual browse after visual QA; cosmetic only, no task verifier or tasks.jsonl impact.
…ty review) Replace generated SVG art and the custom card theme with real imagery scraped from bandcamp.com pages (covers, banners, artist images, and type-matched merch photos), align the shell with the real site (light theme, wordmark header, category nav, selling-right-now strip, light release pages), and give the Gift cards / Editorial / Radio categories their own pages instead of reusing discover. Assets ship through the HF bundle (see PR #82); tasks.jsonl and verifiers are unchanged.
The newer shared harness no longer injects an authoritative start_url into run trajectories. Derive the local origin from recorded step URLs instead (and treat a no-op run without steps as having no navigation evidence), while keeping the previous behaviour whenever start_url is present. Adds a regression test for both shapes.
…p.com Cover art in grids toggles play state instead of navigating (titles still open the release); album pages get the music/merch/community tabs, player with a real elapsed-time counter, format blocks, artist card and discography; home gains the live Selling right now feed (flags, relative times, pause/unpause), Bandcamp Daily and Album of the Day sections; an /artists page backs the Most supported link; category tabs highlight the active filter; the compare page is two columns with a static form.
…g copy (visual QA round 008)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bandcamp's answer verifiers could accept tenfold prices and incomplete Discover navigation, and the mobile cart overflowed at 390px. This follow-up fixes the grading checks and responsive layout, discloses the fictional catalog/illustrative artwork, and pins the merged production assets.
e82d584da9eb2b138f8db71fb28f50438860b17dand the verified 49-site manifest.Merge order: #36 → #79 → #104 → this PR, using merge commits. The original contribution by @Lxr-max and the subsequent reviewer commits are retained through ancestry-preserving merge resolutions. This PR delivers the follow-up changes after those bases land; it does not replace or squash them.
HF: dataset PR #94 is merged. Its complete Bandcamp archive supersedes the earlier #26/#82 bundles. SHA256:
63b81ffdcafc3738f5a91dbb18680126140e294074cf437c6730ba3acf83b68b. No archive was repacked; all 51 unrelated dataset files and the prior 48 registered archive hashes are unchanged.Validation: fresh standard asset fetch for all 49 sites; standard Docker build; all 49 SQLite seeds valid; 49/49 sites healthy and homepages HTTP 200; browser wishlist mutation followed by a byte-identical, stable reset. The final PR tree is identical to tested commit
1695b64(imagesha256:def4a707ce1daf6f61f34f269dbf5feb18a4e54b3842a0b760dafcde75125e62). Docker build used host networking because the default bridge is unavailable; all normal build gates ran.Grading/UI validation: 139 unit tests passed, 2 skipped; 18 desktop and 3 mobile scripted browser replays passed; 20 targeted grading controls matched expectations; all 18 saved desktop trajectories regraded successfully after the merged-HF pin. These are scripted browser regressions, not independent vision-agent runs. No secondary LLM judge ran. Image publication/deployment is outside this PR.
Integration outcome: #36 and #79 merged with separate merge commits. #104 was still a draft, so its direct merge was rejected; this PR included its preserved head through merge
d90cebd, and GitHub automatically marked #104 merged when #146 landed. All original heads are ancestors of mainaf160a72b00f62a0ebc6f853232fbcb9e42b335a, whose complete tracked tree exactly matches the tested tree. No squash or force push was used.