Conversation
Review —
|
|
Reviewer takeover continues in Draft PR #101: https://github.com/aiming-lab/WebHarbor/pull/101\n\nPaired reviewed asset candidate: https://huggingface.co/datasets/ChilleD/WebHarbor/discussions/71. The original mirror contribution and authorship are preserved; the Draft remains pending independent blind review and final visual reconciliation. |
Review: validate NBA mirror and task grading (#30)
|
Thanks for the reviewer takeover and follow-up work in #101. Since #101 has now been merged and explicitly supersedes this PR while preserving the original NBA mirror contribution and attribution, I’m closing #30 to avoid keeping a duplicate PR open. Thanks @jackjin1997 and the maintainers for reviewing, fixing, and integrating the NBA mirror. |
Summary
Adds a new WebHarbor mirror site for NBA.com:
nba40015in the container, typically exposed ashttp://localhost:41015/during testingThe mirror implements an NBA.com-style sports information portal with homepage stories, games/schedule, playoffs, draft, fantasy, stats, standings, teams, players, news/articles, search, tickets, store/cart/checkout, and account flows. Runtime behavior is deterministic and uses SQLite plus local static assets only.
Seeded data
Major seeded model counts:
Functional coverage
Implemented routes and flows include:
Benchmark tasks
sites/nba/tasks.jsonlcontains 20 WebVoyager-schema benchmark tasks.Task coverage includes:
The tasks were revised to reduce benchmark leaks:
alice.j@test.com/TestPass123!task leakageTBD arenatask from an older schedule layoutPaired HuggingFace dataset PR
Paired asset-side PR:
<PASTE_HUGGINGFACE_DATASET_PR_LINK_HERE>
The HF asset bundle is
nba.tar.gzand contains:nba/instance_seed/nba.dbnba/static/images/nba/static/external_cache/After the HF PR merges, this code PR should bump
.assets-revisionto the merged dataset revision.Visual fidelity
The NBA mirror is designed to closely follow NBA.com rather than a generic Bootstrap demo:
static/images/; no runtime network fetchesScreenshot evidence to attach to this PR:
http://localhost:41015//schedule/draft/fantasy/playoffs/stats/standingsTest plan
python3 -m py_compile sites/nba/app.py./scripts/build.sh webharbor:devnbaalive on port40015//games/schedule/playoffs/draft/fantasy/stats/standings/teams/players/news/search/tickets/shop/loginPOST /reset/nbareturned"ready": trueReset evidence
Notes for reviewers
sites/nba/image/is a local scratch/reference directory and should not be included in the final GitHub PR.