Add AKC mirror site - #40
Sun-sunshine06 wants to merge 1 commit into
Conversation
Susan571
left a comment
There was a problem hiding this comment.
Reviewer checklist (WebHarbor Review Guide)
Reviewer note: Source-level review (checked out pull/40/head). The mechanical Docker pipeline (build, curl 200, md5 reset) was not run in my environment — please pair with a Docker-capable mechanical pass.
Visual fidelity: ❌ FAIL
- The most built-out of this contributor's set (app ~522 lines; breed_detail/compare/selector/events/articles; branded AKC header). But breed imagery is the
/breed-art/<slug>.svgplaceholder — real AKC pages are defined by distinctive breed photography, so this fails the real-images check.
Functional depth: ✅ PASS
- Breed browse with group/size filters, breed detail, breed selector with real scoring logic (energy/grooming/apartment matching), compare, expert-advice articles, events with registration, login/register, save-breed, owner-profile update. Trait ratings (energy/grooming 1–5) mirror AKC's real trait scales.
Task quality: ⚠️ Request changes (10 tasks)
- Good:
AKC--1(breed selector: apartment + moderate energy + low grooming → recommend),--2(compare Golden Retriever vs Border Collie energy — decided on the compare page, not leaked),--5(filter events to Training → CGC test city/state),--8(register a dog for a webinar = real state change). - Only 10 tasks (need 15–20);
AKC--3leaks the password; confirm group/temperament answers require the detail page, not the card.
Verdict: Request changes
(1) Use real breed photos; (2) provide 15–20 tasks with more ≥5-step reasoning; (3) remove the credential leak; (4) verify card-vs-detail answer placement. Best functional depth of the contributor's set.
Addresses review on PR aiming-lab#53: - Rebase onto current main; register healthline as index 16 -> port 40016 (append after merriam_webster in websyn_start.sh + control_server.py; Dockerfile EXPOSE -> 40000-40016). merriam_webster preserved. - websyn_start.sh site-count comments reconciled to 17. - .assets-revision pinned to HF PR aiming-lab#40 (clean tarball, no macOS AppleDouble junk, based on current main -> all 17 tarballs). Bump to merged SHA once HF PR aiming-lab#40 lands. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
I'm taking over the review and remediation of this AKC contribution. I'll build a separate The review will cover current-main integration (this branch is based on |
|
Restarting this takeover as a fresh review pass. The earlier private case and The existing review scope and authorship commitment remain unchanged. Please avoid duplicating the AKC review while this pass is active. |
|
The restarted review now has a Draft integration PR: #134. The pinned AKC asset candidate is HF dataset PR #97: https://huggingface.co/datasets/ChilleD/WebHarbor/discussions/97. The original contribution remains preserved with @Sun-sunshine06 authorship. Current status: 13/13 real UI runs pass deterministic grading; independent blind review and a fresh full Docker build are still pending, so nothing is ready to merge. |
Summary
Verification
Note