Conversation
Contributor
Draft
4 tasks
Contributor
|
后续 Review PR 已创建:#104(https://github.com/aiming-lab/WebHarbor/pull/104)。 该 PR 保留 @reacher-z 的贡献归属,基于当前 main 接管原贡献,并在那里跟踪剩余 review/asset blocker:
后续 Review 请转到 #104。 |
This was referenced Sep 13, 2026
jackjin1997
pushed a commit
to jackjin1997/WebHarbor
that referenced
this pull request
Sep 14, 2026
Points .assets-revision at ChilleD/WebHarbor discussions/79 so this branch fetches and builds without waiting for that PR to merge. The commit is upstream's current pin plus phet_simulations.tar.gz; every other archive is byte-identical, verified by comparing the file OIDs of both trees. Temporary. Repin to the merge commit once aiming-lab#79 lands. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jackjin1997
pushed a commit
to jackjin1997/WebHarbor
that referenced
this pull request
Sep 14, 2026
…sets Upstream merged fedex, webmd_doctor, healthline, kaggle and nvidia while this branch was in review, so take the next free slot. .assets-revision points at ChilleD/WebHarbor discussions/86 so this branch fetches and builds without waiting for that PR to merge. That commit is upstream's current pin b7e605c plus phet_simulations.tar.gz, with every other archive byte-identical - checked by comparing the file OIDs of both trees, which matters because the earlier asset PR aiming-lab#79 predated the NVIDIA repin and would have regressed those images. Temporary; repin to the merge commit once aiming-lab#86 lands. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer contribution
This builds on #36 while preserving XuanRui LI's original Bandcamp commit and authorship. The reviewer changes are isolated in a second commit.
What changed
main, retaining Merriam-Webster and assigning Bandcamp the next available port40016judge_rubricandverifier_pathcontracts without leaking ananswerfieldVerification
python3 -m unittest discover -s sites/bandcamp/verify -p 'test_*.py' -v: 7 test groups passpy_compile, JSONL parsing, shell syntax,git diff --check, and asset checks passAsset dependency
The companion asset submission remains ChilleD/WebHarbor discussion #26. It should be merged/pinned before this environment is treated as self-contained.
This branch independently uses the next free port on current
main. If the Cookpad reviewer PR #78 lands first, I will rebase this branch and move Bandcamp to40017so both environments remain conflict-free.