重複するbuild.ymlワークフローを削除 - #4
Merged
Merged
Conversation
WASMビルドはdeploy.yml、テストはtest.yml(PlatformIO)で カバーされているため、build.ymlの全ジョブが不要になった。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.ymlを削除理由
build.ymlの3ジョブは他のワークフローで全てカバーされている:deploy.yml(WASMビルド + GitHub Pagesデプロイ)test.yml(PlatformIOpio test)test.yml(ビルド+テスト両方実行)Test plan
test.ymlでネイティブテストが通ることを確認済み（PR PlatformIOネイティブテスト環境とGitHub Actions CIを追加 #3）deploy.ymlでWASMビルド+デプロイが動作することを確認済み