Elasticsearch 7 support#165
Open
atrsa wants to merge 7 commits into
Open
Conversation
…csearch 7 while keeping lib compatible with previous version; specifying version explicitly during setup is now required
|
This pull request introduces 1 alert when merging 9aadaf4 into 3e766c7 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 50eed21 into 3e766c7 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 951230c into 3e766c7 - view on LGTM.com new alerts:
|
atrsa
force-pushed
the
issues/issue158-support-for-elasticsearch7
branch
from
38faddc to
683564b
Compare
|
This pull request introduces 1 alert when merging 683564b into 3e766c7 - view on LGTM.com new alerts:
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Changing setup.py to support both ES 6 and ES 7 via extras_require in setup.py. Omitting it will render library broken.
Tests are rewritten to support both versions.
Are there changes in behavior for the user?
Support for ES7, the installation now requires an explicit version in square brackets:
or
Related issue number
#158
Checklist
CONTRIBUTORS.txt<Name> <Surname>.CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.