feat: read welcome message from a variable - #207
Merged
pohmelie merged 4 commits intoAug 4, 2026
Conversation
Contributor
Author
|
Just a tiny thing that came up when I was using the library. It can be achieved by overriding the If you want, I can also add a CLI option. For comparison, |
pohmelie
requested changes
Aug 3, 2026
rwakulszowa
force-pushed
the
feat/modifiable-welcome-message
branch
2 times, most recently
from
August 3, 2026 15:04
3da80cf to
a3456fc
Compare
Collaborator
|
I will fix linter errors later today |
rwakulszowa
changed the title
Allow setting a welcome message (aka banner) through a variable. This is the message that the server replies with on the first connection.
rwakulszowa
force-pushed
the
feat/modifiable-welcome-message
branch
from
August 4, 2026 15:47
a3456fc to
8c4283c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 97.94% 97.94% -0.01%
==========================================
Files 6 6
Lines 2095 2094 -1
==========================================
- Hits 2052 2051 -1
Misses 43 43 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Thank you for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Allow setting a welcome message (aka banner) through a class variable. This is the message that the server replies with on the first connection.
Are there changes in behavior for the user?
Yes, but it's just a hardcoded string.
Checklist