-
Notifications
You must be signed in to change notification settings - Fork 415
Centralize toolchain and target compatibility version. #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use 22 for toolchain and 11 for source compatibility.
| steps: | ||
| - name: Checkout DeepLinkDispatch | ||
| uses: actions/checkout@v2 | ||
| - name: Set up JDK 22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
25 did not work with robolectric and it was not worth to figure it out.
elihart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great clean up, thanks 👍
| } | ||
|
|
||
| // Apply consistent JVM toolchain and target to all subprojects | ||
| subprojects { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kind of crazy how hard it is just to set a standard version for the whole project 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, but better to have it spread out everywhere...
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [com.airbnb:deeplinkdispatch-processor](https://redirect.github.com/airbnb/deeplinkdispatch) | `7.2.1` → `7.2.2` |  |  | | [com.airbnb:deeplinkdispatch](https://redirect.github.com/airbnb/deeplinkdispatch) | `7.2.1` → `7.2.2` |  |  | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>airbnb/deeplinkdispatch (com.airbnb:deeplinkdispatch-processor)</summary> ### [`v7.2.2`](https://redirect.github.com/airbnb/DeepLinkDispatch/releases/tag/7.2.2): DeepLinkDispatch v7.2.2 [Compare Source](https://redirect.github.com/airbnb/deeplinkdispatch/compare/7.2.1...7.2.2) ##### What's Changed - Update AGP to 8.13.2 by [@​rossbacher](https://redirect.github.com/rossbacher) in [airbnb/DeepLinkDispatch#385](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/385) - Optimize chunkOnModifiedUtf8ByteSize from O(n²) to O(n) by [@​Nepomuk5665](https://redirect.github.com/Nepomuk5665) in [airbnb/DeepLinkDispatch#386](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/386) - Upgrade GitHub Actions for Node 24 compatibility by [@​salmanmkc](https://redirect.github.com/salmanmkc) in [airbnb/DeepLinkDispatch#390](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/390) - Centralize toolchain and target compatibility version. by [@​rossbacher](https://redirect.github.com/rossbacher) in [airbnb/DeepLinkDispatch#388](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/388) - Fix chunking algo for surrogate pairs by [@​rossbacher](https://redirect.github.com/rossbacher) in [airbnb/DeepLinkDispatch#389](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/389) ##### New Contributors - [@​Nepomuk5665](https://redirect.github.com/Nepomuk5665) made their first contribution in [airbnb/DeepLinkDispatch#386](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/386) - [@​salmanmkc](https://redirect.github.com/salmanmkc) made their first contribution in [airbnb/DeepLinkDispatch#390](https://redirect.github.com/airbnb/DeepLinkDispatch/pull/390) **Full Changelog**: <airbnb/DeepLinkDispatch@7.2.1...7.2.2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/keelim/all). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Mi4xIiwidXBkYXRlZEluVmVyIjoiNDIuOTIuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOlsiVVBEQVRFLW1pbm9yLXBhdGNoIl19-->
Use 22 for toolchain and 11 for source compatibility.