Remote Config failing to load, and setting 'remoteConfig' to false does nothing

[crisps-for-breakfast]

About 9 days ago, our airbrake/phpbrake v0.8.0 connection with CodebaseHQ stopped reporting errors; it was working previously

On closer inspection, the remote config is failing to load - "Project not found. Disabled config returned." I'm assuming this is an issue with CodebaseHQ's remote config file disappearing, but it appears to have been hosted on airbrake.io previously

Honesty I'm a bit confused about the whole remote config thing and whether it's even necessary, I wasn't even aware it existed before, so I attempted to turn it off with

new Notifier([
        'host' => 'xxx',
        'projectId' => 'yyy',
        'projectKey' => 'zzz',
        'environment' => 'eee',
        'remoteConfig' => false,
 ]);

but the Notifier constructor contains the lines:

if (empty($opt['remoteConfig'])) {
    $opt['remoteConfig'] = true;
}

which seems to ensure $opt['remoteConfig'] is alwaystrue

This feels like a bug as Notifier::remoteErrorConfig() checks this value when deciding whether to use the RemoteConfig::DEFAULT_CONFIG

I'm going to attempt to downgrade to 0.7.5

[crisps-for-breakfast]

Downgrading to 0.7.5 solves the issue - perhaps I have misunderstood the remote config option

[gbirke]

I also unwittingly used this feature, cause by the empty call. It should use isset instead.

[gaxweb]

CodebaseHQ stopped reporting errors

Still having the same issue with versions newer than 0.7.5 OOTB.

In the array that the notify() method returns there's an error entry of: [error] => phpbrake: error notifications are disabled. The fault seems to lie here:

https://github.com/airbrake/phpbrake/blob/c5c354934fa879a70e0e6167f7269fe39935beca/src/Notifier.php#L319C9-L322C10

If remoteConfig is disabled, it just returns and doesn't send the request anymore. Why? Is that intended behaviour? Surely not, right? If I comment out the return $notice; line, the request arrives at CodebaseHQ just fine.

I suggest the change:

if ($this->opt['remoteConfig'] === true && !$this->errorNotifications())

It must not enter that if-clause, if remoteConfig isn't even enabled.

P.S.: If a sendNotice() method doesn't actually send anything, I'd throw an exception.