Skip to content

Minor refactoring and improvement#2

Open
niladam wants to merge 1 commit into
airlst:masterfrom
niladam:minor-refactoring
Open

Minor refactoring and improvement#2
niladam wants to merge 1 commit into
airlst:masterfrom
niladam:minor-refactoring

Conversation

@niladam
Copy link
Copy Markdown

@niladam niladam commented Jun 29, 2021

This pull request is just a minor refactoring doing the following:

  1. Renames the service provider from ServiceProvider to AirLSTCoreServiceProvider;
  2. Replaces boolval with (bool) since the latter is 6x faster (and also reduces cognitive load);
  3. Adds installation instructions along with config publishing instructions.
  4. Fixes the previous instructions that used an incorrect namespace for the facade class.
  5. Makes use of throw_unless helper in Laravel to simplify the WorkerCreator class.

@niladam
Copy link
Copy Markdown
Author

niladam commented Jun 29, 2021

Since i didn't have any instructions on how the pull request should be made (via a develop branch for example) i decided to make the pull request against the master one. If that goes against your guidelines you can of course simply merge this in an entirely different branch :)

@orkhanahmadov @mThallerWeb if you have any questions i'll gladly answer them :)

@niladam
Copy link
Copy Markdown
Author

niladam commented Jun 29, 2021

Also, please note that this is a breaking change since the name of the service provider has been changed, so it's not backwards compatible and therefore i think it requires at least a minor version change (so it's not a patch). Personally i would suggest 0.1.0.

@isarphilipp
Copy link
Copy Markdown

@claude review

2 similar comments
@isarphilipp
Copy link
Copy Markdown

@claude review

@isarphilipp
Copy link
Copy Markdown

@claude review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants