Minor refactoring and improvement#2
Open
niladam wants to merge 1 commit into
Open
Conversation
Author
|
Since i didn't have any instructions on how the pull request should be made (via a develop branch for example) i decided to make the pull request against the master one. If that goes against your guidelines you can of course simply merge this in an entirely different branch :) @orkhanahmadov @mThallerWeb if you have any questions i'll gladly answer them :) |
Author
|
Also, please note that this is a breaking change since the name of the service provider has been changed, so it's not backwards compatible and therefore i think it requires at least a minor version change (so it's not a patch). Personally i would suggest 0.1.0. |
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is just a minor refactoring doing the following:
ServiceProvidertoAirLSTCoreServiceProvider;boolvalwith(bool)since the latter is 6x faster (and also reduces cognitive load);throw_unlesshelper in Laravel to simplify theWorkerCreatorclass.