Catch broken Wi-Fi/SSH helper CLIs in boot-smoke - #229
Merged
Conversation
The helpers source shared libs from the overlay; a stale lib-dir default broke all Wi-Fi/SSH calls and backup export while unit suites stayed green via their env-seam overrides. Assert exit 0 + parseable JSON on the booted image. Also fix the stale validator path in CLAUDE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The apl-wifi and apl-ssh helpers recently shipped with a stale library path that broke every Wi-Fi and SSH operation plus backup export on flashed devices, and no CI job noticed: the helpers' own unit suites override the library-dir env seam, and boot-smoke never invoked them. Add a boot-smoke probe that runs
apl-wifi list --jsonandapl-ssh status --jsonon the booted image and requires exit 0 with parseable JSON on stdout — the exact failure mode was a sourcing error on stderr with empty stdout. Also corrects the validator path in CLAUDE.md.