enables uploading from web url#2
Open
MichaelWhi wants to merge 1 commit intoaismail:masterfrom
MichaelWhi:upload_url-feature
Open
enables uploading from web url#2MichaelWhi wants to merge 1 commit intoaismail:masterfrom MichaelWhi:upload_url-feature
MichaelWhi wants to merge 1 commit intoaismail:masterfrom
MichaelWhi:upload_url-feature
Conversation
CHANGES IN API: * upload_face was renamed to new_face (in terms of expected behavior)
Owner
|
I'll review this today - sorry for the delay :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES IN API:
´new_face´ checks, whether the "file_name" contains http:// and if so, will supply the URL to the API, otherwise it will upload it (like before).
Also works for the ´recognize_faces´ method.