Add input validation to POST /tasks - #12
Merged
Merged
Conversation
Reject a missing, non-string, or whitespace-only title with HTTP 400 and a clear JSON error instead of creating an invalid task. Add tests covering the invalid cases and that no task is created. Fixes: #1 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
POST /taskspreviously created a task even whentitlewas missing or blank, allowing empty/garbage records into the store. This adds proper input validation so invalid requests are rejected up front.What changed
sample-app/src/tasks/routes.ts— thePOST /handler now validatestitlebefore callingstore.create. A missing, non-string, or whitespace-onlytitlereturns HTTP400with{ error: "title is required and must be a non-empty string" }and no task is created.sample-app/src/app.test.ts— added three tests covering the invalid cases (missing, non-string, whitespace-only title), each asserting a400response and that the store stays empty. The existing happy-path test is unchanged.Verification
npm test-> 11 passed (was 8)npm run build-> clean type-checkFixes: #1