feat: add isolated Grace website editor VM - #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Network safety corrections
The original revision enabled the global NixOS nftables service, which defaults to flushing all rules on this host's stateVersion. That implementation has been replaced.
grace-editor-firewallservice owns ONLYinet grace_editor; no global nftables/NAT service enablement, ruleset flush, or ip_tables blacklist.autostart = false; the VM requires its installation and firewall services.BindsTo+Afterstop the VM before firewall removal.Validation
patroclusandpatroclusStrippedtoplevel derivation evaluation.nix flake check --no-buildremains blocked by the existing agenix dev-shell package using removedsubstituteAll.Two small prerequisite fixes in a separate commit allow normal patroclus evaluation: provide
isStripped = falseexplicitly and normalize the duplicate rclone secret-file definition to the same string value.See
components/website-editor/README.mdfor test and start commands. Merge the companion website workflow PR before first boot. The guest still needs its own Copilot login and repository push credential.