ci: build the docs site on pull requests - #93
Merged
Merged
Conversation
docs.yml only ran on push to main, so a dependency bump could pass every required check and then break the deploy after merging. zensical 0.0.60 is exactly that case: it removed the search `engine` option, and the build aborts with exit 1 whether or not --strict is passed. This repo does not set that option, so it is the gap rather than the symptom being fixed here. The PR build reuses this workflow instead of duplicating the command, so it cannot drift from what deploys. Configure Pages and Upload Artifact are push-only; deploy was already guarded on the branch ref. The pull_request trigger is unfiltered on purpose: once this is a required check, a paths filter would leave unrelated PRs waiting on a status that never arrives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs.ymlran only on push tomain, so a dependency bump could pass every required check and break the Pages deploy after merging.zensical 0.0.60 removed the search
engineoption and aborts the build with exit 1 regardless of--strict. This repo does not set that option, so what lands here is the missing gate, not a symptom. Two sister repos did set it and were fixed separately.The PR build reuses this workflow rather than duplicating the build command elsewhere, so it cannot drift from what actually deploys.
Configure PagesandUpload Artifactare push-only;deploywas already guarded on the branch ref.The
pull_requesttrigger is unfiltered deliberately. Once this job is a required check, a paths filter would leave every unrelated PR waiting on a status that never arrives.