docs(impl): record the hero brief, and why the layout waits on it - #99
Merged
Merged
Conversation
The landing page centres its copy because the artwork is square and symmetric. The legibility fix made that copy readable, but a veil dense enough to carry text also dims the art beneath it, so the real fix is an image with empty ground to set type on. Records the prompt, the three files a regeneration has to produce, and the CSS that changes once one exists. The aspect ratio is the load-bearing part: a 1:1 source forecloses a left-aligned column whatever is drawn in it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hero prompt existed only in a chat transcript, which is not somewhere it can be found again. This puts it in
IMPL.mdwith the parts that were missing from it.The under-specified bit was the aspect ratio. The current heroes are near-square —
phalanx-hero.pngis 1678x1641 — and a square frame cannot hold an empty left third, so a 1:1 source forecloses a left-aligned column no matter what is drawn in it.background: ... / containalso letterboxes a square image in a wide viewport, which is the banding visible on the page today.A regeneration needs three files, not one: the dark hero, the light hero, and the 1200x630 OG card that
overrides/main.htmlpoints at. The note records which stylesheet line reads each.It also records what changes in
extra.cssonce an asset exists, including the specific trap: the scrim must be measured from the copy column's own edge rather than from a share of the viewport. That is what made ariadne's hero unreadable at 1440px, fixed in ajbarea/ariadne#46, and this layout would otherwise reproduce it.No code changes.