chore: type-check techne, and raise the toolchain floors - #68
Merged
Merged
Conversation
techne was the only sister without ty. `make lint` now runs it over scripts/, plugins/ and tests/, which is the same set ruff already covers. The one diagnostic it found is the pdf skill's `import typst`, deliberately deferred to render time and installed by the skill rather than declared, so it carries a targeted suppression. ruff floor 0.16.6 -> 0.16.8 and pytest 8.4 -> 9.0.3, matching what the lock already resolves and what the rest of the fleet pins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
techne was the only sister running no type checker at all.
make lintnow runstyoverscripts/,plugins/andtests/— the same paths ruff already lints — so the plugin's shipped Python is checked the way every other sister's source is.tyfound exactly one thing: the pdf skill'simport typst, which is deferred insiderender()because the skill installs Typst at render time rather than declaring it as a dependency. That import carries a targeted# ty: ignore[unresolved-import]and a line saying why; nothing else is suppressed.Floors raised to match what the lock already resolves and what the fleet pins:
ruff0.16.6 -> 0.16.8,pytest8.4 -> 9.0.3.Verification
make lint— ruff check, ruff format --check (29 files), andtyall pass.make testwithTECHNE_NO_TEX=1— 123 passed, 6 skipped.uv lock --check— consistent.