Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ajirthan
force-pushed
the
feat/a11y-wcag-baseline
branch
from
July 16, 2026 06:39
89d1224 to
e098288
Compare
ajirthan
force-pushed
the
feat/a11y-wcag-baseline
branch
from
July 16, 2026 06:54
a45bc4d to
d38f868
Compare
…archPlaceholder is empty
ajirthan
force-pushed
the
feat/a11y-wcag-baseline
branch
from
July 16, 2026 08:38
b56fef5 to
9b110f2
Compare
…stead of inputProps
Click/keyboard-opened menus ignore mouse-leave; hover-opened menus use a short leave delay so the pointer can reach the sibling popover paper.
Call onToggleExpand on hover-open only when the item is not already expanded, so the full sidebar reflects nested items inspected via hover.
Treat only trimmed non-empty aria values as accessible names so a whitespace aria-label cannot block placeholder-based naming.
Spread consumer props first, then apply menu-owned aria-controls, aria-expanded, and a meaningful aria-label so open state cannot be clobbered.
ajirthan
force-pushed
the
feat/a11y-wcag-baseline
branch
from
July 16, 2026 09:27
e8a1b0f to
1cc4572
Compare
ajirthan
force-pushed
the
feat/a11y-wcag-baseline
branch
from
July 17, 2026 03:41
9d1e271 to
ef16ee8
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ef16ee8. Configure here.
| id={popoverId} | ||
| autoFocusItem={popoverOpen && popoverOpenedByClick} | ||
| disablePadding | ||
| > |
There was a problem hiding this comment.
MenuList uses non-menuitem buttons
Medium Severity
The collapsed nested-items popover was switched to MenuList with autoFocusItem and the trigger exposes aria-haspopup="menu", but each entry is still a styled ListItemButton instead of a MenuItem. MUI’s MenuList keyboard handling and menu semantics expect menuitem children, so arrow-key navigation and assistive-tech menu behavior may not match the trigger’s menu popup role.
Reviewed by Cursor Bugbot for commit ef16ee8. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@storybook/addon-a11y+ test-runner CI (WCAG 2.1 A/AA tags; fail PRs on new violations)#FF7300,Form.CardButton) with linked upstream issuespackages/oxygen-ui-docs/ACCESSIBILITY.md+ Storybook page) and contributor policyRelated to wso2/oxygen-ui#557 (Phase 1 — WCAG 2.1 AA baseline bootstrap). Does not close the epic (Phase 2 / WCAG 2.2 AA remains open).
Follow-ups
Test plan
pnpm --filter @wso2/oxygen-ui test(includesaccessibility.test.tsx)pnpm build:storybook+pnpm --filter @wso2/oxygen-ui-docs test:storybook:ciwso2/oxygen-uiissues (#558 / #562)Made with Cursor