Conversation
ajirthan
force-pushed
the
fix/a11y-notification-panel-560
branch
from
July 23, 2026 06:40
7acab2c to
309f752
Compare
Owner
Author
|
@BugBot review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1eca600. Configure here.
… better synchronization and state management
…vior and state management
Owner
Author
|
Superseded by upstream PR: wso2#568 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
aria-label="Notifications"(overridable; empty/whitespace falls back)liveAnnouncementAddresses wso2/oxygen-ui#560 (parent epic #557).
Commits
aria-label+ live-region infrastructureTest plan
pnpm --filter @wso2/oxygen-ui exec vitest run src/components/accessibility.test.tsxcolor-contrast(A11y: Brand primary #FF7300 fails WCAG AA 4.5:1 text contrast (Classic/WSO2 themes) wso2/oxygen-ui#558) exceptionNote
Medium Risk
New public props and context API require consumers to call setLiveAnnouncement for new items; behavior is well-tested but changes how notification UX should be wired for screen readers.
Overview
NotificationPanel now gives the drawer a default accessible name (
aria-label="Notifications", overridable; empty/whitespace keeps the default) via drawerslotProps.paper, and adds a visually hidden politerole="status"live region for status updates.New arrivals are not inferred from list child count (tabs/filters would false-positive). Apps publish explicitly with the
liveAnnouncementprop oruseNotificationPanel().setLiveAnnouncement, only while the panel is open; repeated identical text remounts the live region so assistive tech can hear it again.NotificationPanelContextalso exposesopenfor compound children.Docs and Storybook are updated (including a LiveAnnouncements story); wso2#560 is resolved and removed from follow-ups.
accessibility.test.tsxadds regression coverage for naming, live-region behavior, and edge cases (close, reopen, persistent closed).Reviewed by Cursor Bugbot for commit 8fc331d. Bugbot is set up for automated code reviews on this repo. Configure here.