Open
Conversation
Owner
|
Wow, thanks for the PR! I'll try and take a close look this weekend. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a couple of TODOs to generate tables at compile time. This PR mostly does that.
In
rsec16,generatorsis now generate byrsec16/internal/genby way of a//go:generatestatement.In
gf2p16,expTableandlogTableare similarly generated bygf2p16/internal/gen.I wanted to do the same with
mulTable, but the generated file was over 200MB. Instead I converted it to use a lazy-loaded cache. I also addedgr2p16.LoadCaches()which will preloadmulTableCachein case you don't want to lazy-load that.I realize this PR is somewhat out of the blue. I just happened onto this repo when looking into par2 and thought I might speed have a go at a streaming API. That didn't work out, but I figured I could at least contribute this bit.