fix(optimize-sorting): standardize experiment storage, add --focus allowlist, add attribution column - #1442
Closed
colehurwitz wants to merge 1 commit into
Closed
fix(optimize-sorting): standardize experiment storage, add --focus allowlist, add attribution column#1442colehurwitz wants to merge 1 commit into
colehurwitz wants to merge 1 commit into
Conversation
Sentrux Quality ReportAbsoluteDiff (vs base branch) |
colehurwitz
force-pushed
the
factory/run-fd0799c1
branch
3 times, most recently
from
September 2, 2026 14:13
b08eef5 to
387e3e9
Compare
…lowlist, add attribution column
colehurwitz
force-pushed
the
factory/run-fd0799c1
branch
from
September 2, 2026 14:15
387e3e9 to
5a2ee41
Compare
Collaborator
Author
|
Superseded by unified PR — see #1443 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1441
Changes
Fix 1: Standardize Experiment Storage — Updated 9 path references from
.factory/sorting/experiments.jsonlto.factory/experiments/optimize-sorting.jsonl. Addedmigrate_experimentsFnNode for one-time migration (shutil.copy2preserves old file). Updated edge wiring:lock_baseline → migrate_experiments → select_tier. Added experiments file toselect_tierreads set.Fix 2: Add optimize-sorting to --focus Mode Allowlist — Added
"optimize-sorting"to the tuple in_validate_late_flags()and updated the error message string.Fix 3: Cross-Reference Code Changes vs Stage Speedups — Inserted attribution logic into
_ARCHIVE_RESULT_PROMPT_TEMPLATEthat cross-referencesgit diff HEAD~1 --name-onlyagainst stage names with 2σ noise threshold. ReplacedStatuscolumn withAttributioncolumn in PR comment table. Added attribution summary after the table.Verification
factory workflow validate optimize-sortingfactory workflow export-skillssorting/experiments.jsonl)optimize-sortingin --focus allowlistruff checkon both files