Skip to content

Fix obsidian shell-out to use obsidian-cli instead of obsidian #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramansrivastava wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix obsidian shell-out to use obsidian-cli instead of obsidian #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions factory/obsidian/notes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def _obsidian_create(name: str, content: str, vault: str = "factory") -> bool:
try:
result = subprocess.run(
[
"obsidian",
"obsidian-cli",
"create",
f"vault={vault}",
f"name={name}",
Expand All @@ -165,7 +165,7 @@ def _obsidian_search(query: str, vault: str = "factory", limit: int = 10) -> str
try:
result = subprocess.run(
[
"obsidian",
"obsidian-cli",
"search",
f"vault={vault}",
f"query={query}",
Expand Down
4 changes: 2 additions & 2 deletions tests/test_obsidian.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def test_write_experiment_tries_cli_first(
original_run = subprocess.run

def mock_run(*args, **kwargs):
if args and args[0] and args[0][0] == "obsidian":
if args and args[0] and args[0][0] == "obsidian-cli":
calls.append(args[0])
return Mock(returncode=1) # CLI fails
return original_run(*args, **kwargs)
Expand All @@ -298,7 +298,7 @@ def mock_run(*args, **kwargs):
monkeypatch.setattr("factory.obsidian.notes._obsidian_create", _real_obsidian_create)
path = write_experiment_note("test-project", sample_record)
# Should have tried CLI
assert any("obsidian" in str(c) for c in calls)
assert any("obsidian-cli" in str(c) for c in calls)
# Should have fallen back to file write
assert path.exists()

Expand Down
Loading