Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes file logging configurable via an environment variable and prevents startup failures when the log file can’t be opened (e.g., due to read-only filesystems), aligning with the Kubernetes ReadOnlyRootFilesystem issue in #205.
Changes:
- Add
LOG_FILEenv var support to configure the log file path or disable file logging entirely. - Wrap file handler initialization in error handling so missing permissions/log path issues don’t crash the app.
- Document
LOG_FILEin the README environment variables section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Documents LOG_FILE usage for configuring/disabling file logging |
| powerdns_api_proxy/logging.py | Adds LOG_FILE handling and graceful failure when file logging can’t be enabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kuhball
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #205
The following is now possible:
On missing permissions for the file an error is logged, but the app still starts.
I would like to deactivate the log to file functionality entirely as default, but that would be a breaking change.
Maybe if we do a v2 someday.