Rewriting core logic to be (hopefully) cleaner, and address some outstanding issues#51
Open
frootbirb wants to merge 11 commits into
Open
Rewriting core logic to be (hopefully) cleaner, and address some outstanding issues#51frootbirb wants to merge 11 commits into
frootbirb wants to merge 11 commits into
Conversation
Author
…shing, kids. Also added tests to address the specific errors people listed in their issues
Author
frootbirb
changed the title
Reformatted the test cases to be more clearly divided into use cases Added new test cases for some edge cases I forgot about tweaked error handling to account for inconsistent behavior around decimal-only numbers and punctuation
Added support to ignore $ and made it easier to ignore other currency symbols in the future Added support for suffixes (e.g. "$150k" -> 150000) Added "nil" as a word option for zero Fixed a bug where a number word followed by a period would be treated as a different number word (allowing things like "thousand thousand.") Added support for indexing to find actual numbers as well as number words Added new tests for new functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed that all the unit tests succeed as before, added some new ones to account for some raised issues