Fixing a lot of bugs, massive refactoring, added function to replace numbers in-place in sentences#67
Open
TurqW wants to merge 1 commit into
Open
Fixing a lot of bugs, massive refactoring, added function to replace numbers in-place in sentences#67TurqW wants to merge 1 commit into
TurqW wants to merge 1 commit into
Conversation
…numbers in-place in sentences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numwords_to_sentences isn't perfect - it can't tell the difference between e.g. "one thousand, two hundred, and three" = 1203 and "four, seven, twelve, three" = "4, 7, 12, 3", currently the former would give "1203" and the latter would give "26". Good enough for my purposes, though, and considering the number of bugs in the old version...