Support Arrays Nested Type & Add Tests#45
Open
gallejesus wants to merge 14 commits into
Open
Conversation
Bugfix/client
Fix arrays
Fixing bad schema when nullable in DB
Adding new test
Fixing proyections
# Conflicts: # tests/test_core.py
Author
|
Hi, any news on this? |
Owner
|
Thank you for contribution. The code like fine. But will the project have building issues if merged? |
akurdyukov
requested changes
Apr 8, 2025
| # ARRAY_COL = Column(Array(Integer), primary_key=False, nullable=True) | ||
| # __table_args__ = ( | ||
| # engines.MergeTree(order_by="id", primary_key=["id"]), | ||
| # ) |
Owner
There was a problem hiding this comment.
This code seems to be dead, please remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we have overwritten some logic from singer sdk to allow nested array type, as well as fix the nullable default fallback.
Also we've added some test scenarios.
IMPORTANT. As this changes were made some time ago, the behaviour wrt nullable & optional was different. From singer-sdk v0.35.1 if a field is not required, even though it may not be declared as nullable, the schema detects it as nullable. This makes one of the tests (discovery_against_file) fail. If this behaviour is accepted we can change the test assertion to validate those non key fields as nullable.
But, giving my two cents, this behavior is not correct as it can lead to having non nullable fields in origin database converted into nullable fields in target due to this schema interpretation. It's something we can try to overwrite in the tap.
What do you think? Let's discuss :)