fix(sdk): make Python SDK installable via pip/uv - #12
Merged
Merged
Conversation
The generated sdks/python/pyproject.toml declared `license = "NoLicense"`.
As a bare string, setuptools validates project.license as an SPDX
expression; "NoLicense" is not valid SPDX, so setuptools (>=77) rejects it
and the table forms aren't matched either, breaking `pip install` / `uv add`
from git. Switch to the table form `license = { text = "NoLicense" }`, which
builds cleanly, and add a post-generation sed in the sdk-python Make target
so the fix survives the next openapi-generator run.
Also unblock CI: gofmt the previously unformatted internal/db and sdks/go
files, and drop an unused `assertFilter` field in TestBuildSearchFilter that
tripped golangci-lint's `unused` check.
alainrk
force-pushed
the
fix/python-sdk-license-metadata
branch
from
May 27, 2026 03:52
c8be129 to
7ac04d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdks/python/pyproject.tomlshippedlicense = "NoLicense". As a bare string, setuptools validatesproject.licenseas an SPDX expression —"NoLicense"isn't valid SPDX, so setuptools (≥77) rejects it ("0 matches"), and the table forms aren't matched either. This breakspip install git+...anduv addfrom this repo.license = { text = "NoLicense" }, which builds cleanly (verified withuv build --wheel).sedin thesdk-pythonMake target (mirroring the existing Go module-path rewrite) so the fix survives the nextopenapi-generatorrun.Why this matters
Consumers importing the SDK via
uvcurrently can't install it at all — the build fails during metadata validation before any code is touched.Test plan
cd sdks/python && uv build --wheelsucceedsuv add "cashout-sdk @ git+https://github.com/alainrk/cashout.git#subdirectory=sdks/python"resolves in a downstream projectmake sdk-pythonregenerates and the license line remains in table form🤖 Generated with Claude Code