fix: optimize segment queries and add timeout to recipient count#352
Merged
Conversation
Rewrite correlated subqueries in BuildSegmentQuery to non-correlated GroupBy+Contains patterns so EF Core emits efficient joins instead of N+1 SELECT COUNT(*) calls (~30s → <3s). Add missing 12s timeout to previewSegmentCount() frontend call to prevent indefinite spinner. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
alanw707
added a commit
that referenced
this pull request
Apr 10, 2026
…ndex The previous segment query rewrite (PR #352) changed C# structure but not the generated SQL — navigation property Count() inside Select() still produced a correlated subquery per UserProfile row (~30s). This rewrites uploadsByUser to use an explicit Join + GroupBy on the ProcessedImages table, generating a single-pass GROUP BY aggregate that uses the existing IX_ProcessedImages_UserProfileId_IsOriginalUpload index. Frontend: remove full-page "Loading…" replacement for the list view — show the table shell (headers, empty state) immediately so the page feels instant. Also adds IX_MarketingCampaigns_CreatedAt for the ORDER BY in GetCampaignsAsync, and fixes the reviews route missing loadComponent (Angular 19 validation). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BuildSegmentQueryto non-correlatedGroupBy+Containspatterns — EF Core now emits efficientIN (SELECT ...)joins instead of N+1SELECT COUNT(*)per user row (~30s → <3s)timeout(12000)topreviewSegmentCount()in the campaigns admin UI so the spinner clears after 12s with an error message instead of hanging indefinitelyTest plan
🤖 Generated with Claude Code