⚡ Bolt: Prevent unnecessary AppBackground re-renders#62
Conversation
Co-authored-by: alazndy <78882672+alazndy@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Wrapped the
AppBackgroundcomponent inReact.memoand assigned itsdisplayNameto ensure debugging remains clear.🎯 Why:
AppBackgroundsits at the top level of the widget tree insideApp.tsx. SinceApp.tsxhandles complex and frequent state updates—like drag-and-drop actions, widget reordering, clock ticks, and layout updates—the massiveAppBackground(which contains images, SVGs, and potentially expensive DOM elements like glow orbs) was re-rendering unnecessarily every time an unrelated state change occurred.📊 Impact: Reduces rendering overhead during interactive events (like dragging widgets or opening modals) by preventing the background tree from re-computing when its props (like
bgConfigandactiveTheme) have not changed.🔬 Measurement: Verify by running the application in development mode with React Developer Tools' "Highlight updates when components render" enabled. Dragging widgets or waiting for the clock to tick no longer causes
AppBackgroundto flash. Build compilation passes normally.PR created automatically by Jules for task 5589254451298462564 started by @alazndy