Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

πŸ’‘ What: Replaced O(N) array filtering with O(1) Map lookups in useQuestionsFirestore hook.
🎯 Why: getQuestionsByWorld was performing a linear scan of all questions every time it was called. availableWorlds was also iterating all questions to find unique worlds.
πŸ“Š Impact: Lookups for world questions are now instantaneous (O(1)). World list generation is now O(W) instead of O(N) (where W is number of worlds).
πŸ”¬ Measurement: Verified with new unit test src/hooks/__tests__/useQuestionsFirestore.test.tsx ensuring correct Map population and retrieval.


PR created automatically by Jules for task 6456320172949676878 started by @albertoivo

- Replaced O(N) filtering in `getQuestionsByWorld` with O(1) Map lookup
- Replaced O(N) mapping in `availableWorlds` with O(W) Map keys iterator
- Added unit test to verify optimization and behavior
- Cleaned up dependency order in hook for correct memoization
@google-labs-jules
Copy link
Contributor Author

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 72ea385):

https://pyexplorer-cd32d--pr107-perf-optimize-use-qu-72v9nx8t.web.app

(expires Thu, 29 Jan 2026 21:21:57 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: 916b4905e0cdc420f3368c8eb19b2f2e90c3be61

@albertoivo albertoivo marked this pull request as ready for review January 23, 2026 09:36
@albertoivo albertoivo merged commit 2dd7f5a into main Jan 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants