docs: simplify frontend Sentry config vars by aldy505 · Pull Request #35 · aldy505/atrium

aldy505 · 2026-02-22T02:51:49Z

Only FRONTEND_SENTRY_* env vars are used at runtime, build-time VITE_SENTRY_* options removed from docs and code

test: add runtime-config test ensuring VITE vars ignored

Co-Authored-By: GitHub Copilot noreply@agents.md

Copilot

Pull request overview

This PR simplifies frontend Sentry configuration by removing build-time VITE_SENTRY_* fallbacks and standardizing on runtime FRONTEND_SENTRY_* values served via /api/runtime-config.

Changes:

Update /api/runtime-config to read only FRONTEND_SENTRY_* (drop VITE_SENTRY_* fallback).
Update frontend Sentry bootstrap to initialize only from runtime config (no import.meta.env.VITE_* usage).
Update docs/templates and add a test intended to ensure VITE_* vars are ignored.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/runtime-config.test.ts	Adds a test for runtime-config behavior around ignoring `VITE_SENTRY_*`.
src/server/index.ts	Removes `VITE_SENTRY_*` fallback in runtime config endpoint response.
src/app/sentry.client.ts	Removes build-time Sentry config fallbacks; relies on runtime config and skips init without DSN.
README.md	Updates quick start/docs and removes `VITE_SENTRY_*` env var documentation.
.env.example	Replaces Vite Sentry env vars with `FRONTEND_SENTRY_*` runtime env vars.
.agents/docs/implementation-history.md	Updates internal docs to reflect `FRONTEND_SENTRY_*` only.
.agents/docs/current-state.md	Updates internal docs to reflect runtime-only Sentry configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

README.md

tests/runtime-config.test.ts

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/runtime-config.test.ts

Copilot · 2026-02-22T03:04:34Z

README.md

+### Docker Compose
+
+`edge` tag refers to the default branch.
+


In a Docker Compose context, localhost inside the container refers to the container itself, not sibling services. If this snippet is meant to be a self-contained Compose example, consider adding redis/minio services and using service hostnames (e.g., redis://redis:6379, http://minio:9000). If it’s meant for externally-hosted Redis/MinIO, clarify that in the text so readers don’t copy a non-working default.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-22T03:20:19Z

tests/runtime-config.test.ts

+  it("returns FRONTEND_SENTRY_* values when provided", async () => {
+    vi.stubEnv("FRONTEND_SENTRY_DSN", "front-dsn");
+    vi.stubEnv("VITE_SENTRY_DSN", "vite-dsn");
+    vi.stubEnv("FRONTEND_SENTRY_ENABLE_LOGS", "false");
+
+    const app = Fastify();
+    registerRuntimeConfigRoute(app);
+
+    try {
+      const res = await app.inject({ method: "GET", url: "/api/runtime-config" });
+      expect(res.statusCode).toBe(200);
+      const body = res.json() as any;
+      expect(body.sentry.dsn).toBe("front-dsn");
+      expect(body.sentry.enableLogs).toBe(false);
+    } finally {
+      await app.close();
+    }
+  });


The test only verifies two fields (dsn and enableLogs) but the endpoint returns eight fields (dsn, environment, release, tracesSampleRate, enableLogs, enableMetrics, replaysSessionSampleRate, replaysOnErrorSampleRate). Consider adding assertions for the other fields to ensure the endpoint returns complete and correct data, including default values when environment variables are not set.

Copilot · 2026-02-22T03:20:20Z

src/server/runtime-config.ts

+    return {
+      sentry: {
+        dsn: sentryDsn,
+        environment: process.env.FRONTEND_SENTRY_ENVIRONMENT || config.NODE_ENV,
+        release: process.env.FRONTEND_SENTRY_RELEASE,
+        tracesSampleRate: process.env.FRONTEND_SENTRY_TRACES_SAMPLE_RATE || "0.1",
+        enableLogs: (process.env.FRONTEND_SENTRY_ENABLE_LOGS || "true") !== "false",
+        enableMetrics: (process.env.FRONTEND_SENTRY_ENABLE_METRICS || "true") !== "false",
+        replaysSessionSampleRate: process.env.FRONTEND_SENTRY_REPLAYS_SESSION_SAMPLE_RATE || "0.1",
+        replaysOnErrorSampleRate: process.env.FRONTEND_SENTRY_REPLAYS_ON_ERROR_SAMPLE_RATE || "1.0",
+      },
+    };
+  });


The return value of this endpoint lacks type safety. The client expects a RuntimeSentryConfig type with optional fields, but this function returns an inline object with no type definition. Consider defining a shared type or extracting the RuntimeSentryConfig type from sentry.client.ts to a shared location to ensure type consistency between client and server.

src/server/runtime-config.ts

Only FRONTEND_SENTRY_* env vars are used at runtime, build-time VITE_SENTRY_* options removed from docs and code test: add runtime-config test ensuring VITE vars ignored Co-Authored-By: GitHub Copilot <noreply@agents.md>

Use shared helper in index and tests, removing duplicate implementation docs: fix README grammar for MinIO credentials Co-Authored-By: GitHub Copilot <noreply@agents.md>

close Fastify instances and avoid direct process.env mutation Co-Authored-By: GitHub Copilot <noreply@agents.md>

Add redis/minio services to snippet and note container networking semantics Co-Authored-By: GitHub Copilot <noreply@agents.md>

run oxfmt to satisfy fmt:check Co-Authored-By: GitHub Copilot <noreply@agents.md>

ensure docs are correctly formatted post-merge Co-Authored-By: GitHub Copilot <noreply@agents.md>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-22T03:36:52Z

src/server/index.ts

+// mount shared route helper
+registerRuntimeConfigRoute(app);
+


This refactor removes the previous /api/runtime-config handler that exposed features.enableS3UriCopy (and resolved it via OpenFeature). Because the UI consumes that field to enable the Copy S3 URI feature, moving the route to registerRuntimeConfigRoute needs to preserve that behavior or the feature flag will stop working.

Copilot · 2026-02-22T03:36:52Z

README.md

+| Variable                                       | Required | Default          | Description                                   |
+| ---------------------------------------------- | -------- | ---------------- | --------------------------------------------- |
+| `NODE_ENV`                                     | no       | `development`    | Runtime environment                           |
+| `PORT`                                         | no       | `3000`           | API/web app port                              |
+| `REDIS_URL`                                    | yes      | -                | Redis connection URL                          |
+| `SESSION_TTL_SECONDS`                          | no       | `86400`          | Session TTL in seconds                        |
+| `COOKIE_NAME`                                  | no       | `atrium_session` | Session cookie name                           |
+| `BUCKET_SIZE_CALC_INTERVAL_HOURS`              | no       | `1`              | Background bucket-size job interval (hours)   |
+| `BUCKET_SIZE_MAX_DURATION_MS`                  | no       | `300000`         | Max runtime per bucket size calculation       |
+| `BUCKET_SIZE_MAX_OBJECTS`                      | no       | `1000000`        | Max objects scanned per calculation           |
+| `S3_ENDPOINT`                                  | yes      | -                | S3-compatible endpoint URL                    |
+| `S3_REGION`                                    | yes      | -                | S3 region string                              |
+| `S3_FORCE_PATH_STYLE`                          | no       | `true`           | Use path-style S3 URLs (needed by MinIO)      |


The environment variables table is duplicated starting at this second header row (the same variables are listed twice). This makes the README confusing; please remove the duplicate table block and keep a single authoritative table.

Suggested change

| Variable | Required | Default | Description |

| ---------------------------------------------- | -------- | ---------------- | --------------------------------------------- |

| `NODE_ENV` | no | `development` | Runtime environment |

| `PORT` | no | `3000` | API/web app port |

| `REDIS_URL` | yes | - | Redis connection URL |

| `SESSION_TTL_SECONDS` | no | `86400` | Session TTL in seconds |

| `COOKIE_NAME` | no | `atrium_session` | Session cookie name |

| `BUCKET_SIZE_CALC_INTERVAL_HOURS` | no | `1` | Background bucket-size job interval (hours) |

| `BUCKET_SIZE_MAX_DURATION_MS` | no | `300000` | Max runtime per bucket size calculation |

| `BUCKET_SIZE_MAX_OBJECTS` | no | `1000000` | Max objects scanned per calculation |

| `S3_ENDPOINT` | yes | - | S3-compatible endpoint URL |

| `S3_REGION` | yes | - | S3 region string |

| `S3_FORCE_PATH_STYLE` | no | `true` | Use path-style S3 URLs (needed by MinIO) |

Copilot · 2026-02-22T03:36:53Z

README.md

+      MINIO_ROOT_USER: "minioadmin"
+      MINIO_ROOT_PASSWORD: "minioadmin"
+    ports:
+      - "9000:9000"


The Docker Compose snippet exposes only port 9000 for MinIO, but later in the Quick Start section the README directs users to the MinIO Console on port 9001. Either add a 9001:9001 port mapping (and MinIO console address if needed) or update the later instructions to match what’s actually exposed.

Suggested change

- "9000:9000"

- "9000:9000"

- "9001:9001"

Copilot · 2026-02-22T03:36:53Z

.agents/docs/current-state.md

 - UI supports both manual pagination (**Load more**) and optional auto-load on scroll.
 - UI supports creating folders with validation and navigation on success.
- Frontend Sentry is initialized at runtime via `/api/runtime-config` (with Vite env fallback).
+  <<<<<<< HEAD


This file contains an unresolved git merge conflict marker (<<<<<<< HEAD). Please resolve the conflict and remove all conflict markers before merging; otherwise the docs are left in a broken state.

Suggested change

<<<<<<< HEAD

tests: assert all returned fields and feature flag docs: expose 9001 port for MinIO in compose snippet Co-Authored-By: GitHub Copilot <noreply@agents.md>

post-pull formatting adjustments Co-Authored-By: GitHub Copilot <noreply@agents.md>

Align server tsconfig rootDir/outDir for shared types and remove server import dependency on app types to fix TS6059 across CI jobs. Co-Authored-By: GPT-5.3-Codex <noreply@agents.md>

…ests The runtime-config route uses OpenFeature.getClient().getBooleanValue() to read feature flags, which requires a provider to be configured. Without initialization, the OpenFeature client throws an error and defaults to false. Added beforeAll hook to set up EnvVarProvider, matching the production server configuration that uses EnvVarProvider as a fallback. This allows tests to read ENABLE_S3_URI_COPY from environment variables via vi.stubEnv(). Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

aldy505 requested a review from Copilot February 22, 2026 02:52

Copilot started reviewing on behalf of aldy505 February 22, 2026 02:52 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

README.md Outdated Show resolved Hide resolved

tests/runtime-config.test.ts Outdated Show resolved Hide resolved

aldy505 requested a review from Copilot February 22, 2026 03:03

Copilot AI reviewed Feb 22, 2026

View reviewed changes

aldy505 requested a review from Copilot February 22, 2026 03:16

Copilot started reviewing on behalf of aldy505 February 22, 2026 03:16 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

aldy505 and others added 5 commits February 22, 2026 10:28

docs: simplify frontend Sentry config vars

988dbbf

Only FRONTEND_SENTRY_* env vars are used at runtime, build-time VITE_SENTRY_* options removed from docs and code test: add runtime-config test ensuring VITE vars ignored Co-Authored-By: GitHub Copilot <noreply@agents.md>

refactor: extract runtime-config route and update tests

e8629d0

Use shared helper in index and tests, removing duplicate implementation docs: fix README grammar for MinIO credentials Co-Authored-By: GitHub Copilot <noreply@agents.md>

test: strengthen runtime-config tests with stubEnv and proper cleanup

508473b

close Fastify instances and avoid direct process.env mutation Co-Authored-By: GitHub Copilot <noreply@agents.md>

docs: clarify Docker Compose example with service hostnames

2a3cd61

Add redis/minio services to snippet and note container networking semantics Co-Authored-By: GitHub Copilot <noreply@agents.md>

style: apply formatting fixes

571110a

run oxfmt to satisfy fmt:check Co-Authored-By: GitHub Copilot <noreply@agents.md>

aldy505 force-pushed the agents/docs/simplify-frontend-sentry-config branch from 4dacf9c to 571110a Compare February 22, 2026 03:30

aldy505 and others added 2 commits February 22, 2026 10:32

style: run formatter after resolving conflicts

b8d6934

ensure docs are correctly formatted post-merge Co-Authored-By: GitHub Copilot <noreply@agents.md>

Merge branch 'master' into agents/docs/simplify-frontend-sentry-config

45a7721

aldy505 requested a review from Copilot February 22, 2026 03:33

Copilot started reviewing on behalf of aldy505 February 22, 2026 03:34 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

aldy505 and others added 4 commits February 22, 2026 10:47

feat(runtime-config): add shared types and feature flag support

4104dc5

tests: assert all returned fields and feature flag docs: expose 9001 port for MinIO in compose snippet Co-Authored-By: GitHub Copilot <noreply@agents.md>

style: finalize formatting for shared types and tests

3324717

post-pull formatting adjustments Co-Authored-By: GitHub Copilot <noreply@agents.md>

fix(ci): resolve server typecheck rootDir issues

bb1bce3

Align server tsconfig rootDir/outDir for shared types and remove server import dependency on app types to fix TS6059 across CI jobs. Co-Authored-By: GPT-5.3-Codex <noreply@agents.md>

aldy505 requested a review from Copilot February 23, 2026 04:10

Copilot started reviewing on behalf of aldy505 February 23, 2026 04:10 View session

Copilot AI reviewed Feb 23, 2026

View reviewed changes

aldy505 merged commit 6776841 into master Feb 23, 2026
9 checks passed

aldy505 deleted the agents/docs/simplify-frontend-sentry-config branch February 23, 2026 06:14

		// mount shared route helper
		registerRuntimeConfigRoute(app);

Conversation

aldy505 commented Feb 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants