fix(print): use native controls and full page width - #329
Draft
PathGao wants to merge 4 commits into
Draft
Conversation
Contributor
Author
|
@alecdotdev This is the next linear follow-up after #327. It fixes a confirmed macOS PDF regression specific to exporting while split view is active: the viewer pane retained its inline split flex ratio, so the PDF body used only part of the printable page. I verified the minimal print-only change in an isolated release bundle with a 20-section A4 export. Please merge it after #327; I left it as a draft until that dependency lands. |
PathGao
force-pushed
the
fix/print-split-layout
branch
from
August 1, 2026 08:07
9ad1f07 to
d4e040e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebviewWindow::print(); the browser-levelwindow.print()path can silently do nothing in the bundled apptauri.localhostPlatform behavior
Export as PDFopens the native print sheet, including the platform's existing “Save as PDF…” flow.Export as PDFopens a PDF save dialog, then uses WebView2PrintToPdfwith headers/footers disabled.Validation
npm cinpm run check— 0 errors, 0 warningsnpm test— 128 passingcargo testcargo check --target x86_64-pc-windows-msvcWindows WebView2 output is compile-validated here; visual verification still needs a Windows runtime.
Related: #232
Depends on #337 until its test-only commit is merged.