Skip to content

test: refresh stale toolbar UI contracts #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
PathGao wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −17
Draft

test: refresh stale toolbar UI contracts #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/reloadOpenToolbar.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ test('preview-level open shortcut handles Ctrl/Cmd+O outside Monaco without doub
assert.match(markdownViewer, /cmdOrCtrl[\s\S]*key === 'o'[\s\S]*selectFile\(\)/);
});

test('editor toolbar delegates to Monaco actions and exposes expected Markdown commands', () => {
test('editor toolbar delegates actions and optional payloads to Monaco', () => {
assert.match(markdownViewer, /import EditorToolbar from '\.\/components\/EditorToolbar\.svelte'/);
assert.match(markdownViewer, /<EditorToolbar[\s\S]*onaction=\{\(actionId\) => editorPane\?\.runEditorAction\(actionId\)\}/);
assert.match(editor, /export function runEditorAction\(actionId: string\)/);
assert.match(markdownViewer, /<EditorToolbar[\s\S]*onaction=\{\(actionId, payload\) => editorPane\?\.runEditorAction\(actionId, payload\)\}/);
assert.match(editor, /export function runEditorAction\(actionId: string, payload\?: any\)/);

for (const actionId of [
'fmt-bold',
Expand Down
24 changes: 10 additions & 14 deletions scripts/toolbarCustomizationWiring.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,21 +78,17 @@ test('settings modal does not light-dismiss when clicking the backdrop', () => {
assert.doesNotMatch(settingsComponent, /function handleBackdropClick[\s\S]*onclose\(\)/);
});

test('toolbar settings use collapsed accordions for application and editor toolbars', () => {
const accordionBlocks = Array.from(settingsComponent.matchAll(/<details\s+class="toolbar-settings toolbar-settings-accordion"[\s\S]*?<\/details>/g));

assert.equal(accordionBlocks.length, 2);
assert.match(accordionBlocks[0][0], /settings\.applicationToolbar/);
assert.match(accordionBlocks[1][0], /settings\.editorToolbar/);
assert.match(accordionBlocks[0][0], /<summary class="toolbar-settings-summary">/);
assert.match(accordionBlocks[1][0], /<summary class="toolbar-settings-summary">/);
assert.match(accordionBlocks[0][0], /class="toolbar-settings-chevron"/);
assert.match(accordionBlocks[1][0], /class="toolbar-settings-chevron"/);
for (const block of accordionBlocks) {
assert.doesNotMatch(block[0], /<details[^>]*\sopen(?:[\s=>]|$)/);
test('toolbar settings expose application and editor sections', () => {
const sectionBlocks = Array.from(settingsComponent.matchAll(/<div class="toolbar-section"[\s\S]*?<\/div>\s*<\/div>/g));

assert.equal(sectionBlocks.length, 2);
assert.match(sectionBlocks[0][0], /settings\.applicationToolbar/);
assert.match(sectionBlocks[1][0], /settings\.editorToolbar/);
for (const block of sectionBlocks) {
assert.match(block[0], /class="toolbar-section-header"/);
assert.match(block[0], /class="toolbar-settings-list" role="list"/);
}
assert.match(settingsComponent, /\.toolbar-settings\[open\]\s+\.toolbar-settings-chevron/);
assert.match(settingsComponent, /\.toolbar-settings-summary::-webkit-details-marker/);
assert.doesNotMatch(settingsComponent, /toolbar-settings-accordion/);
});

test('interactive button labels are directly translated for every supported language', () => {
Expand Down
Loading