Repository navigation
Meeting list: banner for a meeting open longer than its period (#204) - #225
Merged
Merged
Conversation
The list shows one line per such meeting, with a link to the meeting page's archive form (the follow-up email's #close fragment). For such a meeting the archive form suggests the nearest date on the pair's cadence that isn't in the past, instead of today plus one period. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #204. Part of #213. Frontend only: no backend, schema or crypto change.
What changes
AnketaList.svelteshows one line above the list for each meeting open longer than its period: "{name}: the 1:1 on {date} isn't closed yet." with a "Close and schedule the next one" link. The link goes to the meeting page's archive form through the follow-up email's existing#closefragment, so there is no new landing code.frontend/src/anketa/longOpen.ts:isOpenPastPeriod()andnextCadenceDate().anketaList.longOpenText, in all 6. The link text reusesanketa.closeAndScheduleNext.docs/user-flow.md,docs/history.md,CLAUDE.md.Where this differs from the issue text
Known gap, not fixed
The banner can show for a meeting the viewer can't open because it is sealed under their previous keypair (after a password reset). The link then lands on the stale-key error page, the same as the ordinary row link. The list response has no field for this, so hiding the banner would need a backend change.
Verification
longOpen.test.ts); the full suite passes (851 tests).dual-actor-anketa.spec.ts, run against the e2e stack: banner, link, focus on the archive form, next date prefilled. The rest of the e2e suite was not re-run locally.code-reviewpass: no blocking findings, the gap above was its only note.🤖 Generated with Claude Code