Repository navigation
Confirm before closing a meeting (#229) - #231
Merged
Merged
Conversation
Closing (archiving) a meeting was one click on a primary button at the bottom of the page, right where people look for Publish. Pressed by mistake, it closed the meeting for both sides and left an unpublished draft unpublishable. The archive form's button and the "not closed" card's "Didn't happen" now open an inline confirmation first. A side with unpublished answers can only "Publish and close"; every other case, the counterpart never having published included, is allowed with a warning. The archive button is secondary and says what it does. Frontend only. See docs/decisions/2026-10-07-confirm-before-archiving.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A new high-severity advisory against source-map-js 1.0.0-1.2.1, a transitive dev dependency, started failing CI's npm audit step. Lockfile only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #229.
Problem
An employee with a filled-in draft scrolled to the bottom of the page for Publish and pressed Archive instead. It closed the meeting for both sides at once, with no question and no way back, and the draft could no longer be published.
What changes
Frontend only: no endpoint, schema or encryption change.
anketa/ArchiveConfirm.svelte) and send nothing. Focus lands on Cancel; a double click or a held Enter only opens it.closeMeeting()publishes first and archives only if that worked.archiveConfirmation()inanketa/archiveConfirmation.ts.Ten new strings in all 6 locales (written by Claude, not native-speaker-reviewed);
anketa.archiveremoved.Not covered: the published side closing while the counterpart is still writing. That needs an undo — #230.
See
docs/decisions/2026-10-07-confirm-before-archiving.md.Verification
archiveConfirmation()(every combination) andhasAnswer(); 943 unit tests pass.code-reviewrounds, the last one clean.generate-demo-fixture.mjs,generate-doc-screenshots.mjs) were updated for the two-step close but not run.🤖 Generated with Claude Code