chore: enforce native stacked pull requests - #2
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 465b9cd97f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## Merge | ||
|
|
||
| Wait for checks and existing merge authorization. Verify the exact target and its unmerged predecessors. Use `gh stack merge <PR-number> --yes` with an explicit allowed merge method; targeting an upper layer includes lower layers. Verify the asynchronous result on GitHub. After bottom-layer merge, verify automatic retargeting and rebase, update the new bottom's dependency to `none`, and sync locally. Do not bypass protection. |
There was a problem hiding this comment.
When an operator follows this runbook in a repository using squash merges, the example passes only --yes even though the same sentence requires an explicit allowed merge method. This contradicts the repository's canonical gh stack merge <PR-number> --yes --squash example and leaves the copyable command without the required strategy; add the appropriate method flag here.
AGENTS.md reference: AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
1 participant
Dependent changes now use native GitHub stacks, while focused independent changes may use a standalone PR. Add shared Codex instructions, dependency declarations, a trusted metadata-only Stack policy controller, and the stack workflow runbook.
The controller validates native membership, immediate parents and ancestry, and rechecks open PRs after changes. It never checks out PR code. Branch protection is activated only after this setup lands and the controller succeeds.
Validation: policy unit and mocked-controller tests passed locally; existing repository CI must pass before merge.
Depends on: none